Added _test package support #199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement GetFullImportPath to resolve full Go import paths, with helper functions findGoMod and parseModulePath. Add example usage in internal/gomod/example_test.go and extensive unit tests covering various scenarios and edge cases. Include testdata for simple and nested modules.
Introduce a new PackageTest option in Options, Header, and render logic to support generating tests in a separate `_test` package. Update import handling, templates, and related tests. Add corresponding test data for the new behavior.
Removed temporary variable and console output used for debugging in `options.go`. Directly pass `b.Bytes()` to `imports.Process` and eliminate unnecessary `fmt.Println` statements, cleaning up the code without altering functionality.
IlyasYOY
commented
Oct 27, 2025
Author
There was a problem hiding this comment.
I must mention that the gomod was generated by AI and reviewed by myself.
Everything else was done manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @cweill!
I’ve put together a sketch implementation that addresses the problem discussed in issue #33.
Thanks again for the thorough integration tests—they were incredibly helpful in shaping this approach! 🙏
Looking forward to your thoughts.
What this PR does
PackageTestflag inOptions(and related structs) to generate tests in a_testpackage.github.com/cweill/gotests/internal/gomodand uses it to resolve full import paths whenPackageTest && Exported.PackageTestthrough the rendering pipeline.render.TestFunctionnow receivespackageTestandpackageName.header.tmpl,function.tmpl,call.tmpl) now emit_testpackage names and handle qualified calls correctly.GetFullImportPath,findGoMod,parseModulePath.example_test.go.PackageTestbehavior and switched aioutil.WriteFilecall to the newer0o644octal literal.models.Headerto includePackageTest.